Bug Summary

File:pam/afs_auth.c
Location:line 131, column 6
Description:Value stored to 'set_expires' is never read

Annotated Source Code

1/*
2 * Copyright 2000, International Business Machines Corporation and others.
3 * All Rights Reserved.
4 *
5 * This software has been released under the terms of the IBM Public
6 * License. For details, see the LICENSE file in the top-level source
7 * directory or online at http://www.openafs.org/dl/license10.html
8 */
9
10#include <afsconfig.h>
11#include <afs/param.h>
12
13#include <roken.h>
14
15#ifdef HAVE_SYS_WAIT_H1
16#include <sys/wait.h>
17#endif
18
19#include <afs/kautils.h>
20
21#include <security/pam_appl.h>
22#include <security/pam_modules.h>
23
24#include "afs_message.h"
25#include "afs_util.h"
26
27
28#define RET(x){ retcode = (x); goto out; } { retcode = (x); goto out; }
29
30extern int
31pam_sm_authenticate(pam_handle_t * pamh, int flags, int argc,
32 const char **argv)
33{
34 int retcode = PAM_SUCCESS;
35 int errcode = PAM_SUCCESS;
36 int code;
37 int origmask;
38 int logmask = LOG_UPTO(LOG_INFO)((1 << ((6)+1)) - 1);
39 int nowarn = 0;
40 int use_first_pass = 0;
41 int try_first_pass = 0;
42 int ignore_uid = 0;
43 uid_t ignore_uid_id = 0;
44 char my_password_buf[256];
45 char *cell_ptr = NULL((void *)0);
46 /*
47 * these options are added to handle stupid apps, which won't call
48 * pam_set_cred()
49 */
50 int refresh_token = 0;
51 int set_token = 0;
52 int dont_fork = 0;
53 /* satisfy kdm 2.x
54 */
55 int use_klog = 0;
56 int set_expires = 0; /* This option is only used in pam_set_cred() */
57 int got_authtok = 0; /* got PAM_AUTHTOK upon entry */
58 PAM_CONST char *user = NULL((void *)0), *password = NULL((void *)0);
59 afs_int32 password_expires = -1;
60 char *torch_password = NULL((void *)0);
61 int i;
62 PAM_CONST struct pam_conv *pam_convp = NULL((void *)0);
63 int auth_ok;
64 struct passwd unix_pwd, *upwd = NULL((void *)0);
65 char upwd_buf[2048]; /* size is a guess. */
66 char *reason = NULL((void *)0);
67 pid_t cpid, rcpid;
68 int status;
69 struct sigaction newAction, origAction;
70
71
72#ifndef AFS_SUN5_ENV
73 openlog(pam_afs_ident, LOG_CONS0x02 | LOG_PID0x01, LOG_AUTH(4<<3));
74#endif
75 origmask = setlogmask(logmask);
76
77 /*
78 * Parse the user options. Log an error for any unknown options.
79 */
80 for (i = 0; i < argc; i++) {
81 if (strcasecmp(argv[i], "debug") == 0) {
82 logmask |= LOG_MASK(LOG_DEBUG)(1 << (7));
83 (void)setlogmask(logmask);
84 } else if (strcasecmp(argv[i], "nowarn") == 0) {
85 nowarn = 1;
86 } else if (strcasecmp(argv[i], "use_first_pass") == 0) {
87 use_first_pass = 1;
88 } else if (strcasecmp(argv[i], "try_first_pass") == 0) {
89 try_first_pass = 1;
90 } else if (strcasecmp(argv[i], "ignore_root") == 0) {
91 ignore_uid = 1;
92 ignore_uid_id = 0;
93 } else if (strcasecmp(argv[i], "ignore_uid") == 0) {
94 i++;
95 if (i == argc) {
96 pam_afs_syslog(LOG_ERR3, PAMAFS_IGNOREUID39,
97 "ignore_uid missing argument");
98 ignore_uid = 0;
99 } else {
100 ignore_uid = 1;
101 ignore_uid_id = (uid_t) strtol(argv[i], (char **)NULL((void *)0), 10);
102 if ((ignore_uid_id < 0) || (ignore_uid_id > IGNORE_MAX1000)) {
103 ignore_uid = 0;
104 pam_afs_syslog(LOG_ERR3, PAMAFS_IGNOREUID39, argv[i]);
105 }
106 }
107 } else if (strcasecmp(argv[i], "cell") == 0) {
108 i++;
109 if (i == argc) {
110 pam_afs_syslog(LOG_ERR3, PAMAFS_OTHERCELL47,
111 "cell missing argument");
112 } else {
113 cell_ptr = (char *)argv[i];
114 pam_afs_syslog(LOG_INFO6, PAMAFS_OTHERCELL47, cell_ptr);
115 }
116 } else if (strcasecmp(argv[i], "refresh_token") == 0) {
117 refresh_token = 1;
118 } else if (strcasecmp(argv[i], "set_token") == 0) {
119 set_token = 1;
120 } else if (strcasecmp(argv[i], "dont_fork") == 0) {
121 if (!use_klog)
122 dont_fork = 1;
123 else
124 pam_afs_syslog(LOG_ERR3, PAMAFS_CONFLICTOPT38, "dont_fork");
125 } else if (strcasecmp(argv[i], "use_klog") == 0) {
126 if (!dont_fork)
127 use_klog = 1;
128 else
129 pam_afs_syslog(LOG_ERR3, PAMAFS_CONFLICTOPT38, "use_klog");
130 } else if (strcasecmp(argv[i], "setenv_password_expires") == 0) {
131 set_expires = 1;
Value stored to 'set_expires' is never read
132 } else {
133 pam_afs_syslog(LOG_ERR3, PAMAFS_UNKNOWNOPT1, argv[i]);
134 }
135 }
136
137 /* Later we use try_first_pass to see if we can try again. */
138 /* If use_first_pass is true we don't want to ever try again, */
139 /* so turn that flag off right now. */
140 if (use_first_pass)
141 try_first_pass = 0;
142
143 if (logmask && LOG_MASK(LOG_DEBUG)(1 << (7)))
144 pam_afs_syslog(LOG_DEBUG7, PAMAFS_OPTIONS17, nowarn, use_first_pass,
145 try_first_pass, ignore_uid, ignore_uid_id,
146 refresh_token, set_token, dont_fork, use_klog);
147
148 /* Try to get the user-interaction info, if available. */
149 errcode = pam_get_item(pamh, PAM_CONV, (PAM_CONST void **)&pam_convp);
150 if (errcode != PAM_SUCCESS) {
151 pam_afs_syslog(LOG_WARNING4, PAMAFS_NO_USER_INT18);
152 pam_convp = NULL((void *)0);
153 }
154
155 /* Who are we trying to authenticate here? */
156 if ((errcode =
157 pam_get_user(pamh, &user,
158 "login: ")) != PAM_SUCCESS) {
159 pam_afs_syslog(LOG_ERR3, PAMAFS_NOUSER2, errcode);
160 RET(PAM_USER_UNKNOWN){ retcode = (PAM_USER_UNKNOWN); goto out; };
161 }
162
163 if (logmask && LOG_MASK(LOG_DEBUG)(1 << (7)))
164 pam_afs_syslog(LOG_DEBUG7, PAMAFS_USERNAMEDEBUG3, user);
165
166 /*
167 * If the user has a "local" (or via nss, possibly nss_dce) pwent,
168 * and its uid==0, and "ignore_root" was given in pam.conf,
169 * ignore the user.
170 */
171 /* enhanced: use "ignore_uid <number>" to specify the largest uid
172 * which should be ignored by this module
173 */
174#if defined(AFS_HPUX_ENV) || defined(AFS_DARWIN100_ENV) || defined(AFS_SUN5_ENV)
175#if defined(AFS_HPUX110_ENV) || defined(AFS_DARWIN100_ENV) || defined(AFS_SUN5_ENV)
176 i = getpwnam_r(user, &unix_pwd, upwd_buf, sizeof(upwd_buf), &upwd);
177#else /* AFS_HPUX110_ENV */
178 i = getpwnam_r(user, &unix_pwd, upwd_buf, sizeof(upwd_buf));
179 if (i == 0) /* getpwnam_r success */
180 upwd = &unix_pwd;
181#endif /* else AFS_HPUX110_ENV */
182 if (ignore_uid && i == 0 && upwd && upwd->pw_uid <= ignore_uid_id) {
183 pam_afs_syslog(LOG_INFO6, PAMAFS_IGNORINGROOT26, user);
184 RET(PAM_AUTH_ERR){ retcode = (PAM_AUTH_ERR); goto out; };
185 }
186#else
187#if defined(AFS_LINUX20_ENV) || defined(AFS_FBSD_ENV1) || defined(AFS_DFBSD_ENV) || defined(AFS_NBSD_ENV)
188 upwd = getpwnam(user);
189#else
190 upwd = getpwnam_r(user, &unix_pwd, upwd_buf, sizeof(upwd_buf));
191#endif
192 if (ignore_uid && upwd != NULL((void *)0) && upwd->pw_uid <= ignore_uid_id) {
193 pam_afs_syslog(LOG_INFO6, PAMAFS_IGNORINGROOT26, user);
194 RET(PAM_AUTH_ERR){ retcode = (PAM_AUTH_ERR); goto out; };
195 }
196#endif
197 errcode = pam_get_item(pamh, PAM_AUTHTOK, (PAM_CONST void **)&password);
198 if (errcode != PAM_SUCCESS || password == NULL((void *)0)) {
199 if (use_first_pass) {
200 pam_afs_syslog(LOG_ERR3, PAMAFS_PASSWD_REQ4, user);
201 RET(PAM_AUTH_ERR){ retcode = (PAM_AUTH_ERR); goto out; };
202 }
203 password = NULL((void *)0); /* In case it isn't already NULL */
204 if (logmask && LOG_MASK(LOG_DEBUG)(1 << (7)))
205 pam_afs_syslog(LOG_DEBUG7, PAMAFS_NOFIRSTPASS8, user);
206 } else if (password[0] == '\0') {
207 /* Actually we *did* get one but it was empty. */
208 pam_afs_syslog(LOG_INFO6, PAMAFS_NILPASSWORD21, user);
209 RET(PAM_NEW_AUTHTOK_REQD){ retcode = (PAM_NEW_AUTHTOK_REQD); goto out; };
210 } else {
211 if (logmask && LOG_MASK(LOG_DEBUG)(1 << (7)))
212 pam_afs_syslog(LOG_DEBUG7, PAMAFS_GOTPASS7, user);
213 got_authtok = 1;
214 }
215 if (!(use_first_pass || try_first_pass)) {
216 password = NULL((void *)0);
217 }
218
219 try_auth:
220 if (password == NULL((void *)0)) {
221 char *prompt_password;
222
223 if (use_first_pass)
224 RET(PAM_AUTH_ERR){ retcode = (PAM_AUTH_ERR); goto out; }; /* shouldn't happen */
225 if (try_first_pass)
226 try_first_pass = 0; /* we come back if try_first_pass==1 below */
227
228 if (pam_convp == NULL((void *)0) || pam_convp->conv == NULL((void *)0)) {
229 pam_afs_syslog(LOG_ERR3, PAMAFS_CANNOT_PROMPT6);
230 RET(PAM_AUTH_ERR){ retcode = (PAM_AUTH_ERR); goto out; };
231 }
232
233 errcode = pam_afs_prompt(pam_convp, &prompt_password, 0, PAMAFS_PWD_PROMPT5);
234 if (errcode != PAM_SUCCESS || prompt_password == NULL((void *)0)) {
235 pam_afs_syslog(LOG_ERR3, PAMAFS_GETPASS_FAILED9);
236 RET(PAM_AUTH_ERR){ retcode = (PAM_AUTH_ERR); goto out; };
237 }
238 if (prompt_password[0] == '\0') {
239 pam_afs_syslog(LOG_INFO6, PAMAFS_NILPASSWORD21, user);
240 RET(PAM_NEW_AUTHTOK_REQD){ retcode = (PAM_NEW_AUTHTOK_REQD); goto out; };
241 }
242
243 /*
244 * We aren't going to free the password later (we will wipe it,
245 * though), because the storage for it if we get it from other
246 * paths may belong to someone else. Since we do need to free
247 * this storage, copy it to a buffer that won't need to be freed
248 * later, and free this storage now.
249 */
250
251 strncpy(my_password_buf, prompt_password, sizeof(my_password_buf));
252 my_password_buf[sizeof(my_password_buf) - 1] = '\0';
253 memset(prompt_password, 0, strlen(prompt_password));
254 free(prompt_password);
255 password = torch_password = my_password_buf;
256
257 }
258
259 /* Be sure to allocate a PAG here if we should set a token,
260 * All of the remaining stuff to authenticate the user and to
261 * get a token is done in a child process - if not suppressed by the config,
262 * see below
263 * But dont get a PAG if the refresh_token option was set
264 * We have to do this in such a way because some
265 * apps (such as screensavers) wont call setcred but authenticate :-(
266 */
267 if (!refresh_token) {
268 setpag();
269#ifdef AFS_KERBEROS_ENV
270 ktc_newpag();
271#endif
272 if (logmask && LOG_MASK(LOG_DEBUG)(1 << (7)))
273 syslog(LOG_DEBUG7, "New PAG created in pam_authenticate()");
274 }
275
276 if (!dont_fork) {
277 /* Prepare for fork(): set SIGCHLD signal handler to default */
278 sigemptyset(&newAction.sa_mask);
279 newAction.sa_handler__sigaction_u.__sa_handler = SIG_DFL((__sighandler_t *)0);
280 newAction.sa_flags = 0;
281 code = sigaction(SIGCHLD20, &newAction, &origAction);
282 if (code) {
283 pam_afs_syslog(LOG_ERR3, PAMAFS_PAMERROR14, errno(* __error()));
284 RET(PAM_AUTH_ERR){ retcode = (PAM_AUTH_ERR); goto out; };
285 }
286
287 /* Fork a process and let it verify authentication. So that any
288 * memory/sockets allocated will get cleaned up when the child
289 * exits: defect 11686.
290 */
291 if (use_klog) { /* used by kdm 2.x */
292 if (refresh_token || set_token) {
293 i = do_klog(user, password, NULL((void *)0), cell_ptr);
294 } else {
295 i = do_klog(user, password, "00:00:01", cell_ptr);
296 ktc_ForgetAllTokens();
297 }
298 if (logmask && LOG_MASK(LOG_DEBUG)(1 << (7)))
299 syslog(LOG_DEBUG7, "do_klog returned %d", i);
300 auth_ok = i ? 0 : 1;
301 } else {
302 if (logmask && LOG_MASK(LOG_DEBUG)(1 << (7)))
303 syslog(LOG_DEBUG7, "forking ...");
304 cpid = fork();
305 if (cpid <= 0) { /* The child process */
306 if (logmask && LOG_MASK(LOG_DEBUG)(1 << (7)))
307 syslog(LOG_DEBUG7, "in child");
308 if (refresh_token || set_token)
309 code = ka_UserAuthenticateGeneral(KA_USERAUTH_VERSION1, (char *)user, /* kerberos name */
310 NULL((void *)0), /* instance */
311 cell_ptr, /* realm */
312 (char *)password, /* password */
313 0, /* default lifetime */
314 &password_expires, 0, /* spare 2 */
315 &reason
316 /* error string */ );
317 else
318 code = ka_VerifyUserPassword(KA_USERAUTH_VERSION1, (char *)user, /* kerberos name */
319 NULL((void *)0), /* instance */
320 cell_ptr, /* realm */
321 (char *)password, /* password */
322 0, /* spare 2 */
323 &reason /* error string */ );
324 if (code) {
325 pam_afs_syslog(LOG_ERR3, PAMAFS_LOGIN_FAILED13, user,
326 reason);
327 auth_ok = 0;
328 } else {
329 auth_ok = 1;
330 }
331 if (logmask && LOG_MASK(LOG_DEBUG)(1 << (7)))
332 syslog(LOG_DEBUG7, "child: auth_ok=%d", auth_ok);
333 if (cpid == 0)
334 exit(auth_ok);
335 } else {
336 do {
337 if (logmask && LOG_MASK(LOG_DEBUG)(1 << (7)))
338 syslog(LOG_DEBUG7, "in parent, waiting ...");
339 rcpid = waitpid(cpid, &status, 0);
340 } while ((rcpid == -1) && (errno(* __error()) == EINTR4));
341
342 if ((rcpid == cpid) && WIFEXITED(status)(((status) & 0177) == 0)) {
343 auth_ok = WEXITSTATUS(status)((status) >> 8);
344 } else {
345 auth_ok = 0;
346 }
347 if (logmask && LOG_MASK(LOG_DEBUG)(1 << (7)))
348 syslog(LOG_DEBUG7, "parent: auth_ok=%d", auth_ok);
349 }
350 }
351 /* Restore old signal handler */
352 code = sigaction(SIGCHLD20, &origAction, NULL((void *)0));
353 if (code) {
354 pam_afs_syslog(LOG_ERR3, PAMAFS_PAMERROR14, errno(* __error()));
355 }
356 } else { /* dont_fork, used by httpd */
357 if (logmask && LOG_MASK(LOG_DEBUG)(1 << (7)))
358 syslog(LOG_DEBUG7, "dont_fork");
359 if (refresh_token || set_token)
360 code = ka_UserAuthenticateGeneral(KA_USERAUTH_VERSION1, (char *)user, /* kerberos name */
361 NULL((void *)0), /* instance */
362 cell_ptr, /* realm */
363 (char *)password, /* password */
364 0, /* default lifetime */
365 &password_expires, 0, /* spare 2 */
366 &reason /* error string */ );
367 else
368 code = ka_VerifyUserPassword(KA_USERAUTH_VERSION1, (char *)user, /* kerberos name */
369 NULL((void *)0), /* instance */
370 cell_ptr, /* realm */
371 (char *)password, /* password */
372 0, /* spare 2 */
373 &reason /* error string */ );
374 if (logmask && LOG_MASK(LOG_DEBUG)(1 << (7)))
375 syslog(LOG_DEBUG7, "dont_fork, code = %d", code);
376 if (code) {
377 pam_afs_syslog(LOG_ERR3, PAMAFS_LOGIN_FAILED13, user, reason);
378 auth_ok = 0;
379 } else {
380 auth_ok = 1;
381 }
382 if (logmask && LOG_MASK(LOG_DEBUG)(1 << (7)))
383 syslog(LOG_DEBUG7, "dont_fork: auth_ok=%d", auth_ok);
384 }
385
386 if (!auth_ok && try_first_pass) {
387 password = NULL((void *)0);
388 goto try_auth;
389 }
390
391 /* We don't care if this fails; all we can do is try. */
392 /* It is not reasonable to store the password only if it was correct
393 * because it could satisfy another module that is called in the chain
394 * after pam_afs
395 */
396 if (!got_authtok) {
397 torch_password = NULL((void *)0);
398 (void)pam_set_item(pamh, PAM_AUTHTOK, password);
399 }
400
401 if (logmask && LOG_MASK(LOG_DEBUG)(1 << (7)))
402 syslog(LOG_DEBUG7, "leaving auth: auth_ok=%d", auth_ok);
403 if (code == KANOENT(180484L))
404 RET(PAM_USER_UNKNOWN){ retcode = (PAM_USER_UNKNOWN); goto out; };
405 RET(auth_ok ? PAM_SUCCESS : PAM_AUTH_ERR){ retcode = (auth_ok ? PAM_SUCCESS : PAM_AUTH_ERR); goto out;
};
406
407 out:
408 if (password) {
409 /* we store the password in the data portion */
410 char *tmp = strdup(password);
411 (void)pam_set_data(pamh, pam_afs_lh, tmp, lc_cleanup);
412 if (torch_password)
413 memset(torch_password, 0, strlen(torch_password));
414 }
415 (void)setlogmask(origmask);
416#ifndef AFS_SUN5_ENV
417 closelog();
418#endif
419 return retcode;
420}